Skip to content

ocamlPackages.reason-native.src: set pname and version#484544

Merged
stepbrobd merged 1 commit intoNixOS:masterfrom
jopejoe1:ocaml-reason-native-pname
Jan 29, 2026
Merged

ocamlPackages.reason-native.src: set pname and version#484544
stepbrobd merged 1 commit intoNixOS:masterfrom
jopejoe1:ocaml-reason-native-pname

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Jan 27, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from ulrikstrid January 27, 2026 22:15
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Jan 27, 2026
@stepbrobd
Copy link
Member

stepbrobd commented Jan 29, 2026

i think the xxx-source name wont really affect anything? since the src seems only be used in the packages in this scope

@jopejoe1
Copy link
Member Author

jopejoe1 commented Jan 29, 2026

This gets exposed in our search index and i'm not realy a fan of having a lot of packages called source show up in search.

@stepbrobd
Copy link
Member

stepbrobd commented Jan 29, 2026

got it, could you add a line comment saying so so whoever is bumping this would remember to change the version?

@jopejoe1 jopejoe1 force-pushed the ocaml-reason-native-pname branch from dadb2ec to 8c4deaf Compare January 29, 2026 21:30
stepbrobd
stepbrobd approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@stepbrobd stepbrobd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is not ci-ing

@stepbrobd stepbrobd added this pull request to the merge queue Jan 29, 2026
@jopejoe1
Copy link
Member Author

jopejoe1 commented Jan 29, 2026

CI will be fixed with #485118

Merged via the queue into NixOS:master with commit e36c5bc Jan 29, 2026
25 of 26 checks passed
@jopejoe1 jopejoe1 deleted the ocaml-reason-native-pname branch January 29, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stepbrobd stepbrobd stepbrobd approved these changes

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jopejoe1 @stepbrobd